Skip to content

Mask invitation emails #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2019
Merged

Mask invitation emails #418

merged 1 commit into from
Dec 4, 2019

Conversation

@yoution
Copy link
Contributor

@yoution yoution commented Dec 4, 2019

challenge

remove all eslint disabled;
change one test case in util.spec.js to

chai.should().not.exist(util.maskEmail(null));

otherwise it will show eslint error

maxceem
maxceem approved these changes Dec 4, 2019
View reviewed changes
Copy link
Contributor

@maxceem maxceem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It has been reviewed during the challenge http://www.topcoder.com/challenge-details/30108867/?type=develop and works good.

@maxceem maxceem merged commit 8423d42 into topcoder-platform:dev Dec 4, 2019
@yoution yoution deleted the feature/addemailmask branch December 5, 2019 00:46
@maxceem maxceem mentioned this pull request Dec 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@maxceem maxceem maxceem approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@yoution @maxceem